fix(router): fix tsc errors #23887
Merged
fix(router): fix tsc errors #23887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanBacon
requested review from
ide,
tsapeta,
brentvatne and
marklawlor
as code owners
ENG-9692 Fix the "Cannot write file '/Users/evanbacon/Documents/GitHub/expo/packages/expo-router/build/views/Splash.d.ts' because it would overwrite input file." errors
When building expo-router in expo/expo there are a bunch of these cyclic issues. |
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
|
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|
EvanBacon
added a commit
that referenced
this pull request
Aug 9, 2023
# Why - Like #23887 --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
How
Then track down all instances of
expo-router/build/*being pulled in.