Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(router)!: pull out @bacons/react-views #23889

Merged
merged 5 commits into from
Aug 10, 2023
Merged

chore(router)!: pull out @bacons/react-views #23889

merged 5 commits into from
Aug 10, 2023

Conversation

EvanBacon
Copy link
Contributor

@EvanBacon EvanBacon commented Aug 9, 2023 •
edited

Why

  • Resolve ENG-9691
  • Most of the benefits should be folded back in to Expo upstream.
  • Simplify the codebase.

@linear
Copy link

linear bot commented Aug 9, 2023

ENG-9691 Remove @bacons/react-views

We should be able to just use the new typed environment now.

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Aug 9, 2023
@EvanBacon @expo-bot
Update packages/expo-router/CHANGELOG.md
785404c 
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Aug 10, 2023
@EvanBacon EvanBacon merged commit a3696c2 into main Aug 10, 2023
11 of 14 checks passed
@EvanBacon EvanBacon deleted the @evanbacon/router/pull-bacons-views branch August 10, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marklawlor marklawlor Awaiting requested review from marklawlor marklawlor is a code owner

Assignees
No one assigned
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EvanBacon @expo-bot