feat(router): Move entry registration to expo.
#23891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanBacon
requested review from
ide,
tsapeta,
brentvatne and
marklawlor
as code owners
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
expo-bot
added
bot: passed checks
ide
reviewed
Aug 9, 2023
| const rootTag = createRoot(tag); | ||
| rootTag.render(React.createElement(qualifiedComponent)); | ||
| AppRegistry.runApplication('main', { | ||
| rootTag, |
There was a problem hiding this comment.
Is this property name something we have control over? rootElement would be a more accurate name than rootTag.
There was a problem hiding this comment.
This is the property name for the runApplication method.
There was a problem hiding this comment.
By definition it is, but is it something we have control over?
EvanBacon
added a commit
that referenced
this pull request
Aug 23, 2023
# Why - regression in #23891. - fix static rehydration. - fix react refresh for web in the monorepo. - fix react-native-web warnings. --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
expoentry registration inexpo-routerv2 in order to support static rendering on web.How
Test Plan
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).