-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[expo] Add support for pnpm isolated modules #23937
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expo-bot
added
bot: passed checks
ExpoBot has nothing to complain about
and removed
bot: suggestions
ExpoBot has some suggestions
labels
Aug 13, 2023
tsapeta
approved these changes
Aug 13, 2023
Chatted with @tsapeta, will do another pass / PR with the helper function (described above) once all major issues are resolved. |
EvanBacon
pushed a commit
that referenced
this pull request
Aug 23, 2023
# Why This PR makes the `expo` autolinking scripts compatible with isolated modules (e.g. from pnpm). It's part of other PRs that make our packages compatible and more resilient in monorepo projects. - #23867 - #23926 # How - **iOS:** resolve `expo-modules-autolinking` from the `__dir__` _(current directory of the file `expo/scripts/autolinking.rb`)_ - **Android:** resolve `expo-modules-autolinking` from `expo` location _(there is no __dir__ alternative, so we need to resolve the `expo` > `expo-modules-autolinking` chain from project root)_ # Test Plan - `$ pnpm create expo ./test-isolated-modules -t tabs` - `$ cd ./test-isolated-modules` - Patch expo with the changes from this PR - Both Android and iOS run commands should work: - `$ pnpm expo run:ios` - `$ pnpm expo run:android` Or see this repo: https://github.com/byCedric/expo-pnpm-tests/blob/main/patches/expo%4049.0.6.patch # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This PR makes the
expo
autolinking scripts compatible with isolated modules (e.g. from pnpm). It's part of other PRs that make our packages compatible and more resilient in monorepo projects.How
expo-modules-autolinking
from the__dir__
(current directory of the file
expo/scripts/autolinking.rb
)expo-modules-autolinking
fromexpo
location(there is no dir alternative, so we need to resolve the
expo
>expo-modules-autolinking
chain from project root)Test Plan
$ pnpm create expo ./test-isolated-modules -t tabs
$ cd ./test-isolated-modules
$ pnpm expo run:ios
$ pnpm expo run:android
Or see this repo: https://github.com/byCedric/expo-pnpm-tests/blob/main/patches/expo%4049.0.6.patch
Checklist
npx expo prebuild
& EAS Build (eg: updated a module plugin).