chore: update react-native to 0.72.4 #24044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ENG-9814 Android: ScrollView doesn't scroll to focused input when keyboard appears (fixed in RN 72.4)
See summary here: #23564 (comment) It appears that there was pretty high-vis keyboard interaction regression in RN 72.x that was patched in RN 72.4, so wanted to open the issue to see if we wanted to patch. |
expo-bot
added
the
bot: needs changes
|
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇 ❌ Error: Forbidden file size or format
Generated by ExpoBot 🤖 against a40c5cf |
|
these ci are known to break on sdk-49 🙈 |
Kudo
requested review from
ide,
tsapeta,
brentvatne,
lukmccall,
douglowder and
EvanBacon
as code owners
Kudo
requested review from
brentvatne
and removed request for
brentvatne,
ide,
tsapeta,
douglowder and
EvanBacon
lukmccall
approved these changes
Aug 21, 2023
Kudo
added a commit
that referenced
this pull request
Aug 22, 2023
close ENG-9814 - update react-native to 0.72.4 - [react-native-lab] cherry pick native changes - [babel-preset-expo] bump `metro-react-native-babel-preset@0.76.8` - [android][ios] re-version sdk-49 code - [dev-menu][dev-launcher] rebuild js bundles versioned expo go + sdk 49 project smoke test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
close ENG-9814
How
metro-react-native-babel-preset@0.76.8Test Plan
versioned expo go + sdk 49 project smoke test
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).