[config][cli] Remove classic manifest types #24054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wschurman
force-pushed
the
@wschurman/reorganize-types-2
branch
from
06c2a8c
to
32b071a
Compare
wschurman
force-pushed
the
@wschurman/reorganize-types-3
branch
2 times, most recently
from
733c41f
to
b88f433
Compare
wschurman
changed the title
wschurman
requested review from
Simek,
amandeepmittal,
EvanBacon and
byCedric
as code owners
wschurman
requested review from
douglowder
and removed request for
Simek and
amandeepmittal
wschurman
force-pushed
the
@wschurman/reorganize-types-3
branch
from
b88f433
to
32811bb
Compare
|
Failing test is due to issue in main that was fixed after the base commit of this stack. This is ready for review. |
wschurman
force-pushed
the
@wschurman/reorganize-types-2
branch
from
32b071a
to
c21dc72
Compare
wschurman
force-pushed
the
@wschurman/reorganize-types-2
branch
from
c21dc72
to
fdf61c1
Compare
wschurman
force-pushed
the
@wschurman/reorganize-types-3
branch
from
32811bb
to
29d6234
Compare
wschurman
force-pushed
the
@wschurman/reorganize-types-3
branch
from
29d6234
to
4ff5c30
Compare
expo-bot
added
bot: passed checks
douglowder
approved these changes
Aug 23, 2023
EvanBacon
pushed a commit
that referenced
this pull request
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Remove classic manifest types from
@expo/configand the CLI. This is a breaking change as it removes the--force-manifest-typeflag from the CLI (which was planned).How
Remove types. Remove classic manifest serving from
expo start.Test Plan
Run all tests.
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).