Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[config-types] Remove classic updates #24066

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Conversation

wschurman
Copy link
Member

@wschurman wschurman commented Aug 22, 2023

Why

This removes classic updates from config-types and config plugins.

How

  1. Pull in unversioned schema from https://github.com/expo/universe/pull/13231.
  2. Grep for functions that use the removed field (updates.useClassicUpdates)
  3. Fan out cleanup.

Test Plan

Run all tests.

Checklist

@wschurman
Copy link
Member Author

Broken test is broken on main branch (in commit that this stack is based on). This is ready for review.

Base automatically changed from @wschurman/reorganize-types-3 to main August 23, 2023 18:07
@wschurman wschurman force-pushed the @wschurman/reorganize-types-4 branch from 5cbab14 to 9edfc9c Compare August 23, 2023 18:07
@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Aug 23, 2023
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Aug 23, 2023
@wschurman wschurman merged commit 82ade86 into main Aug 23, 2023
11 checks passed
@wschurman wschurman deleted the @wschurman/reorganize-types-4 branch August 23, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants