Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent double renders when pushing stacks. #24147

Merged
merged 3 commits into from
Aug 28, 2023

Conversation

EvanBacon
Copy link
Contributor

@EvanBacon EvanBacon commented Aug 28, 2023

Why

Prevent double renders by cloning state to avoid leaking state between functions.

How

  • Prevent mutating the input state to avoid invalidating the nested state.

Test Plan

import { Slot } from "expo-router";
export default function RootLayout() {
  return <Slot />
}
  • app/(a)/index.js
import { router, useNavigation } from "expo-router";
import {  View } from "react-native";

export default function App() {
  // const navigation = useNavigation();

  setTimeout(() => {
    router.push("/b");
    // navigation.push("b");
  });
  return (
    <View />
  );
}
  • app/b/index.js
import { usePathname } from 'expo-router';
import { Text, View } from 'react-native';

let i = 0;
export default function Page() {
  const path = usePathname();
  i++;
  return (
    <View style={{ flex: 1, backgroundColor: i > 1 ? "red" : "white" }}>
      <Text>Path: {path}</Text>
    </View>
  );
}

Checklist

EvanBacon and others added 2 commits August 28, 2023 17:52
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Aug 28, 2023
@EvanBacon EvanBacon merged commit cea96f5 into main Aug 28, 2023
8 checks passed
@EvanBacon EvanBacon deleted the @evanbacon/router/proper-fix-838 branch August 28, 2023 23:16
EvanBacon added a commit that referenced this pull request Aug 29, 2023
# Why

- Use a full serial clone to prevent any state leaking. This is a more
thorough implementation of #24147
- No test case for this at the moment but it should scale better. May
come back and make a faster version later.

<!--
Please describe the motivation for this PR, and link to relevant GitHub
issues, forums posts, or feature requests.
-->

# How

<!--
How did you build this feature or fix this bug and why?
-->

# Test Plan

<!--
Please describe how you tested this change and how a reviewer could
reproduce your test, especially if this PR does not include automated
tests! If possible, please also provide terminal output and/or
screenshots demonstrating your test/reproduction.
-->

# Checklist

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).

---------

Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
2 participants