fix: prevent double renders when pushing stacks. #24147
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Prevent double renders by cloning state to avoid leaking state between functions.
How
Test Plan
The testing library doesn't seem to support this case. @marklawlor has been tasked with ensuring the original branch can detect the error https://github.com/expo/expo/compare/%40evanbacon/router/fix-838
Just in case the testing library isn't fixed, I ran locally with:
app/_layout.js
,app/(a)/_layout.js
,app/b/_layout.js
app/(a)/index.js
app/b/index.js
Checklist
npx expo prebuild
& EAS Build (eg: updated a module plugin).