[cli] Misleading build message #24153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ENG-9074 "Creating native project directories (./ios and ./android)" should only print actual directory being created
In this screenshot, I'm running prebuild for iOS via run:ios but the text suggests that it's also creating an Android directory. |
expo-bot
added
bot: passed checks
byCedric
reviewed
Sep 1, 2023
|
We also don't update the gitignore anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Closes ENG-9074
Running
npx expo prebuild -p iosornpx expo run:iosoutputsCreating native project directories (./ios and ./android). Including android in this example is misleading.How
Check what platforms the command is targeting and change output accordingly
Test Plan
Tested locally