fix(router): support push going back to sibling with nested stack from a modal. #24166
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
push
to account for moving between sibling routes which all use the leaf-most nameindex
.How
index
, then use the parent state as the route target. React Navigation would search forindex
when moving toslot/index
via/slot
. This would result in the wrong route being selected:Now we account for index routes by pushing up to
slot
so theStackRouter
can identify the right screen.Test Plan