Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(metro, cli, router): production static web source maps support #24213

Merged
merged 4 commits into from Sep 1, 2023
Merged

feat(metro, cli, router): production static web source maps support #24213

merged 4 commits into from Sep 1, 2023

Conversation

EvanBacon
Copy link
Contributor

Why

How

  • Pass a new setting to the custom serializer when exporting for usage outside of the dev server. This setting will ensure a source map is created with paths relative to the server root.
  • The resources will be adjusted after exporting to reflect the hashed js filename location.
  • When no sourcemap exporting is enabled, the references will be stripped to prevent getting a chrome warning.

Test Plan

  • I added an e2e bundling test for both exporting with and without sourcemaps.

Checklist

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Aug 31, 2023
@EvanBacon EvanBacon mentioned this pull request Aug 31, 2023
Merged
3 tasks
@EvanBacon @expo-bot
Apply suggestions from code review
b65198e 
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Sep 1, 2023
@EvanBacon EvanBacon merged commit 573b0ea into main Sep 1, 2023
9 of 10 checks passed
@EvanBacon EvanBacon deleted the @evanbacon/cli/metro-production-source-maps-on-web branch September 1, 2023 03:04
EvanBacon added a commit that referenced this pull request Sep 1, 2023
@EvanBacon @expo-bot
feat(router, metro-runtime): reduce production web code (#24215)
080145b 
# Why

- Using the new source map support, I was able to identify and remove
some development-only code #24213 --
over ~100kb smaller.

<!--
Please describe the motivation for this PR, and link to relevant GitHub
issues, forums posts, or feature requests.
-->

# How

<!--
How did you build this feature or fix this bug and why?
-->

# Test Plan

<!--
Please describe how you tested this change and how a reviewer could
reproduce your test, especially if this PR does not include automated
tests! If possible, please also provide terminal output and/or
screenshots demonstrating your test/reproduction.
-->

# Checklist

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).

---------

Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marklawlor marklawlor marklawlor approved these changes

@byCedric byCedric Awaiting requested review from byCedric byCedric is a code owner

Assignees
No one assigned
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@EvanBacon @marklawlor @expo-bot