Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): delete @expo/dev-server #24272

Merged
merged 21 commits into from Sep 6, 2023
Merged

Conversation

EvanBacon
Copy link
Contributor

Why

  • I tried this before but the logs endpoint was blocking it.
  • I forked the dev server when I wrote the original expo/cli, been meaning to delete the original for a while. The duplicate code and indirection is making the new server features harder to implement.

How

  • Copy/paste remaining code from @expo/dev-server in to @expo/cli.
  • Delete @expo/dev-server.
  • Drop unused /logs and json parser middleware.
  • Drop logging mocks.
  • Drop experimental Webpack native support.
  • Drop legacy react-native middleware support (no longer needed since everything is versioned).

Test Plan

  • Tests should keep passing.
  • Need to do some actual runs since there aren't any e2e tests for various parts of dev-server.

Checklist

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Sep 5, 2023
@wschurman
Copy link
Member

Change to updates looks fine, will defer to other reviewers for other changes.

Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Sep 5, 2023
@EvanBacon EvanBacon merged commit edeec53 into main Sep 6, 2023
15 of 17 checks passed
@EvanBacon EvanBacon deleted the @evanbacon/cli/drop-deprecated branch September 6, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants