Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reduce unused web code #24294

Merged
merged 7 commits into from
Sep 6, 2023
Merged

Conversation

EvanBacon
Copy link
Contributor

@EvanBacon EvanBacon commented Sep 5, 2023

Why

Web bundles are too big by default, this is one of a series of PRs that will reduce code that is pulled in on web.

How

Because we compile the src of @expo/metro-runtime to CJS, the react-native-web shaking plugin breaks and we import everything. This PR also switches the input for @expo/metro-runtime to be src for both web and native, while using build for Node.js and types.

Test Plan

Checklist

EvanBacon and others added 2 commits September 5, 2023 18:20
@expo-bot
Copy link
Collaborator

expo-bot commented Sep 5, 2023

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

⚠️ Suggestion: Missing changelog entries


Your changes should be noted in the changelog. Read Updating Changelogs guide and consider adding an appropriate entry to the following changelogs:


Generated by ExpoBot 🤖 against a684195

@EvanBacon EvanBacon merged commit 4a8c097 into main Sep 6, 2023
8 checks passed
@EvanBacon EvanBacon deleted the @evanbacon/reduce-unused-web-code branch September 6, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: suggestions ExpoBot has some suggestions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants