Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[go] fix ios expo go crash from exceptions #24305

Merged
merged 2 commits into from Sep 6, 2023
Merged

[go] fix ios expo go crash from exceptions #24305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2fc165a
[go] show build error if classes not implement required protocol inte…
Kudo Sep 6, 2023
dd72501
[go] implement required protocol interfaces
Kudo Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions ios/Exponent.xcodeproj/project.pbxproj
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions ios/Exponent/Kernel/HeadlessApp/EXHeadlessAppRecord.m
View file
Open in desktop
Expand Up @@ -76,6 +76,9 @@ - (void)reactAppManagerIsReadyForLoad:(EXReactAppManager *)appManager
- (void)reactAppManagerDidInvalidate:(EXReactAppManager *)appManager {}
- (void)reactAppManagerFinishedLoadingJavaScript:(EXReactAppManager *)appManager {}
- (void)reactAppManagerStartedLoadingJavaScript:(EXReactAppManager *)appManager {}
- (void)reactAppManagerAppContentDidAppear:(EXReactAppManager *)appManager {}
- (void)reactAppManagerAppContentWillReload:(EXReactAppManager *)appManager {}


# pragma mark - EXAppLoaderDelegate

Expand Down
2 changes: 2 additions & 0 deletions ios/Exponent/Kernel/ReactAppManager/EXReactAppExceptionHandler.m
View file
Open in desktop
Expand Up @@ -51,6 +51,7 @@ - (instancetype)initWithAppRecord:(EXKernelAppRecord *)appRecord
- (void)handleSoftJSExceptionWithMessage:(nullable NSString *)message
stack:(nullable NSArray<NSDictionary<NSString *, id> *> *)stack
exceptionId:(NSNumber *)exceptionId
extraDataAsJSON:(nullable NSString *)extraDataAsJSON
{
// In RN 0.8 this was used to invoke the native red box errors (via `showErrorMessage`).
// The invocation has since been moved into the method that invokes this delegate method.
Expand All @@ -60,6 +61,7 @@ - (void)handleSoftJSExceptionWithMessage:(nullable NSString *)message
- (void)handleFatalJSExceptionWithMessage:(nullable NSString *)message
stack:(nullable NSArray<NSDictionary<NSString *, id> *> *)stack
exceptionId:(NSNumber *)exceptionId
extraDataAsJSON:(nullable NSString *)extraDataAsJSON
{
NSString *description = [@"Unhandled JS Exception: " stringByAppendingString:message];
NSDictionary *errorInfo = @{ NSLocalizedDescriptionKey: description, RCTJSStackTraceKey: stack };
Expand Down