fix(router): infinite renders when using nested boundaries #24317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expo-bot
added
bot: suggestions
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
marklawlor
force-pushed
the
marklawlor/router/errorboundary-infinite-render
branch
from
557a302
to
a0eca5a
Compare
EvanBacon
approved these changes
Sep 11, 2023
EvanBacon
deleted the
marklawlor/router/errorboundary-infinite-render
branch
alanjhughes
pushed a commit
that referenced
this pull request
Sep 14, 2023
# Why #24185 (comment) #24242 # How The qualified route component component loading is slightly unstable, as it calls `fromLoadedRoute` every render. Normally this isn't an issue, as routes typically return a stable component (the `default` export), but when using an ErrorBoundary, this becomes non-stable. # Test Plan # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
#24185 (comment)
#24242
How
The qualified route component component loading is slightly unstable, as it calls
fromLoadedRouteevery render. Normally this isn't an issue, as routes typically return a stable component (thedefaultexport), but when using an ErrorBoundary, this becomes non-stable.Test Plan
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).