Add EX_UPDATES_NATIVE_DEBUG support to Xcode env generator #24366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douglowder
requested review from
wschurman,
tsapeta,
Kudo and
lukmccall
as code owners
Kudo
reviewed
Sep 11, 2023
packages/expo-modules-autolinking/scripts/ios/xcode_env_generator.rb
Outdated
Show resolved
Hide resolved
ide
reviewed
Sep 12, 2023
packages/expo-modules-autolinking/scripts/ios/xcode_env_generator.rb
Outdated
Show resolved
Hide resolved
packages/expo-modules-autolinking/scripts/ios/xcode_env_generator.rb
Outdated
Show resolved
Hide resolved
douglowder
commented
Sep 13, 2023
packages/expo-modules-autolinking/scripts/ios/xcode_env_generator.rb
Outdated
Show resolved
Hide resolved
ide
approved these changes
Sep 13, 2023
douglowder
force-pushed
the
doug/xcode-env-generator-updates
branch
from
53f15d1
to
8b5c78d
Compare
expo-bot
added
bot: passed checks
Co-authored-by: James Ide <ide@users.noreply.github.com>
douglowder
force-pushed
the
doug/xcode-env-generator-updates
branch
from
ff17b2f
to
4b4bfde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
pod installoverwritesxcode.env.localfrom a script inexpo-modules-autolinking. It would be great if this supported the native debug feature ofexpo-updates, specifically the template Xcode project changes in #23602 .How
Modify the
expo-modules-autolinkingscript to detect ifEX_UPDATES_NATIVE_DEBUGis set, and set the correct environment variables to force embedded bundling and disable running the packager.Test Plan
Modified Updates E2E to not set a custom value of
.xcode.env.local. E2E should still pass.Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).