Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metro-config): Normalize paths on Windows machines. #24382

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

EvanBacon
Copy link
Contributor

Why

Test Plan

I don't have a windows machine so I'm just guessing that this is the fix. We've mostly unified all the path collection and this should be a pretty safe change. There's a test against the theoretical value based on the issue repro.

@EvanBacon EvanBacon changed the title Fix exporting paths on Windows machines. fix(metro-config): Normalize paths on Windows machines. Sep 11, 2023
@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Sep 11, 2023
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@EvanBacon EvanBacon merged commit d791306 into main Sep 11, 2023
6 of 7 checks passed
@EvanBacon EvanBacon deleted the @evanbacon/metro-config/fix-exporting-paths branch September 11, 2023 19:08
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Sep 11, 2023
@arun-spar
Copy link

Why

Test Plan

I don't have a windows machine so I'm just guessing that this is the fix. We've mostly unified all the path collection and this should be a pretty safe change. There's a test against the theoretical value based on the issue repro.

I can verify on my windows machine, please let me know how to get these changes to my system.

alanjhughes pushed a commit that referenced this pull request Sep 14, 2023
# Why

- fix #24073

# Test Plan

I don't have a windows machine so I'm just guessing that this is the
fix. We've mostly unified all the path collection and this should be a
pretty safe change. There's a test against the theoretical value based
on the issue repro.

---------

Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@arun-spar
Copy link

image
#24073 (comment)

@arun-spar
Copy link

Any update to this issue: Normalize paths on Windows machines as i am not seeing any resolution for this.
image

expo-env-info 1.0.5 environment info:
System:
OS: Windows 10 10.0.19044
Binaries:
Node: 16.14.0 - C:\Program Files\nodejs\node.EXE
Yarn: 1.22.19 - ~\AppData\Roaming\npm\yarn.CMD
npm: 9.8.1 - C:\Program Files\nodejs\npm.CMD
IDEs:
Android Studio: AI-223.8836.35.2231.11090377
npmPackages:
expo: ~49.0.18 => 49.0.21
react: 18.2.0 => 18.2.0
react-dom: 18.2.0 => 18.2.0
react-native: 0.72.6 => 0.72.6
react-native-web: ~0.19.6 => 0.19.9
Expo Workflow: managed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web publishing JS files renders 404 - also assets path are not correct
3 participants