fix(router): Handle deep dynamic route colliding with passed query pa… #24386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marklawlor
commented
Sep 11, 2023
marklawlor
commented
Sep 11, 2023
expo-bot
added
bot: suggestions
marklawlor
force-pushed
the
marklawlor/router/ENG-9827
branch
from
f58ef22
to
701156b
Compare
expo-bot
added
bot: suggestions
EvanBacon
reviewed
Sep 25, 2023
|
|
||
| renderRouter({ | ||
| index: () => <Redirect href="/test?id=test23" />, | ||
| ':id': () => <Text />, |
There was a problem hiding this comment.
Should also test [...wild] since it is handled a bit differently.
marklawlor
commented
Sep 25, 2023
|
|
||
| renderRouter({ | ||
| index: () => <Redirect href="/test?id=test23" />, | ||
| ':id': () => <Text />, |
There was a problem hiding this comment.
Change to square bracket syntax
github-actions
bot
added
bot: fingerprint changed
and removed
bot: fingerprint compatible
labels
EvanBacon
approved these changes
Oct 4, 2023
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
marklawlor
force-pushed
the
marklawlor/router/ENG-9827
branch
from
438be1f
to
5bb8883
Compare
github-actions
bot
added
bot: fingerprint compatible
and removed
bot: fingerprint changed
labels
github-actions
bot
added
bot: fingerprint changed
and removed
bot: fingerprint compatible
labels
onizam95
pushed a commit
to onizam95/expo-av-drm
that referenced
this pull request
Jan 15, 2024
expo#24386) # Why <!-- Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests. --> # How <!-- How did you build this feature or fix this bug and why? --> # Test Plan <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
How
Test Plan
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).