Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(router): Ignore root HTML automatically in the context module. #24388

Merged
merged 3 commits into from
Sep 12, 2023
Merged

fix(router): Ignore root HTML automatically in the context module. #24388

merged 3 commits into from
Sep 12, 2023

Conversation

EvanBacon
Copy link
Contributor

Why

  • Update the regex in context modules to prevent importing HTML wrappers and API routes. This will cut down on resolution nominally, and decrease the chance that a user will break the transformer that strips API code.

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Sep 12, 2023
EvanBacon and others added 2 commits September 11, 2023 17:49
@EvanBacon @expo-bot
Update packages/expo-router/CHANGELOG.md
30b1de7 
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@EvanBacon
update regex
c03a45d
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Sep 12, 2023
@EvanBacon EvanBacon merged commit 92a316a into main Sep 12, 2023
8 checks passed
@EvanBacon EvanBacon deleted the @evanbacon/router/update-router-imports branch September 12, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marklawlor marklawlor Awaiting requested review from marklawlor marklawlor is a code owner

Assignees
No one assigned
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EvanBacon @expo-bot