Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): Enable tsconfigPaths by default #24490

Merged
merged 8 commits into from
Sep 25, 2023

Conversation

marklawlor
Copy link
Contributor

Why

ENG-9888

How

Test Plan

Checklist

@linear
Copy link

linear bot commented Sep 18, 2023

ENG-9888 Enable tsconfig paths by default in SDK 50

  • Make experiments.tsconfigPaths enabled by default in SDK 50.
  • Update docs to reflect that SDK 50+ is on and SDK 49 is off.
  • Ensure the Jest docs reflect that tsconfig paths must be supported.
  • Update the universe schema description and expo config types to reflect that the experiment is over in SDK 50. Keep the field around and ensure it can be used to disable the feature.
  • Update the Expo CLI, TypeScript, Metro versioned docs to reflect the change.

@expo-bot expo-bot added bot: suggestions ExpoBot has some suggestions bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Sep 18, 2023
@marklawlor
Copy link
Contributor Author

@marklawlor
Copy link
Contributor Author

Keep tsconfig experimental feature. Just default to true

@marklawlor marklawlor marked this pull request as ready for review September 21, 2023 08:52
Co-authored-by: Aman Mittal <amandeepmittal@live.com>
@marklawlor marklawlor merged commit 1c8e3ea into main Sep 25, 2023
11 checks passed
@marklawlor marklawlor deleted the marklawlor/ENG-9888/enable-tsconfig-paths branch September 25, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint changed bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants