[iOS][Android] Add LocalAnthentication#supportedAuthenticationTypes #2450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbarthec
force-pushed
the
@bbarthec/provide-authentication-type
branch
from
130ca69
to
013dca9
Compare
tsapeta
changed the title
tsapeta
requested changes
Oct 18, 2018
| throw new Error(`Unrecognised authentitcation type returned: '${type}'`); | ||
| } | ||
| return acc ? `${acc}, ${typeName}` : typeName; | ||
| }, ''); |
There was a problem hiding this comment.
It might be better to use result.map(() => {...}).join(', ') :)
| typeName = 'FACIAL_RECOGNITION'; | ||
| break; | ||
| default: | ||
| throw new Error(`Unrecognised authentitcation type returned: '${type}'`); |
There was a problem hiding this comment.
authentitcation -> authentication
| static BOOL EXIsTouchIDDevice() | ||
| { | ||
| static BOOL isTouchIDDevice = NO; | ||
| if (@available(iOS 11.0, *)) { |
There was a problem hiding this comment.
@available shouldn't be there or at least not with iOS 11.0, because TouchID is available in iOS 10.0 too
| @@ -6,6 +6,11 @@ | |||
| #import <EXConstantsInterface/EXConstantsInterface.h> | |||
| #import <EXLocalAuthentication/EXLocalAuthentication.h> | |||
|
|
|||
| typedef NS_ENUM(NSInteger, EXAuthenticationType) { | |||
| EXAuthenticationTypeFingerprint = 1, | |||
| EXAuthenticationTypeFacialRecogniotion = 2, | |||
There was a problem hiding this comment.
EXAuthenticationTypeFacialRecogniotion
bbarthec
force-pushed
the
@bbarthec/provide-authentication-type
branch
from
013dca9
to
81b83af
Compare
tsapeta
approved these changes
Oct 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Resolves #2447
Additionally I removed
react-native-svgfromnclthat was causingnclto crash. (this package is dependency ofexponotncl)How
iOS -> used method that was available for
FaceIDand added similar forTouchID.Android -> used method responsible for checking for Fingerprint API.
Test Plan
ncl#LocalAuthenticationScreenhas new button invoking this method.