Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): Improve truncated Metro Node.js errors. #24546

Merged
merged 3 commits into from Sep 20, 2023

Conversation

EvanBacon
Copy link
Contributor

Why

Split errors by lines and measure to ensure we're only tested against libraries with one really long line.

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Sep 20, 2023
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Sep 20, 2023
@EvanBacon EvanBacon merged commit cd4367e into main Sep 20, 2023
6 of 7 checks passed
@EvanBacon EvanBacon deleted the @evanbacon/cli/improve-extended-error-truncation branch September 20, 2023 20:30
EvanBacon added a commit that referenced this pull request Sep 20, 2023
# Why

Split errors by lines and measure to ensure we're only tested against
libraries with one really long line.

---------

Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants