Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router): prevent circular navigation references. #24548

Merged
merged 4 commits into from
Sep 20, 2023

Conversation

EvanBacon
Copy link
Contributor

Why

How

  • clone objects to prevent circular references.

Test Plan

  • Added test that could repro the issue.

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Sep 20, 2023
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
EvanBacon added a commit to expo/router that referenced this pull request Sep 20, 2023
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Sep 20, 2023
EvanBacon added a commit to expo/router that referenced this pull request Sep 20, 2023
* backport expo/expo#24548

* Update routing.ts
@EvanBacon EvanBacon merged commit 0afd420 into main Sep 20, 2023
8 checks passed
@EvanBacon EvanBacon deleted the @evanbacon/router/fix-circular-references branch September 20, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants