fix(cli): fallback to xcrun devicectl for iOS 17
#24635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
expo-bot
added
bot: passed checks
EvanBacon
approved these changes
Sep 27, 2023
byCedric
added a commit
that referenced
this pull request
Sep 27, 2023
Works around issue #24615 This is a dirty workaround and needs further attention. If we want to keep the fast socket connections, we need to implement the new [Quic + XPC](https://github.com/doronz88/pymobiledevice3/blob/master/misc/RemoteXPC.md) protocol. - on iOS 17, there is a new protocol to connect to the device ([Quic + XPC](https://github.com/doronz88/pymobiledevice3/blob/master/misc/RemoteXPC.md)) - If the `com.apple.debugserver` service can't be launched, use the fallback option - Fallback is just `xcrun devicectl` - `$ yarn create expo ./test-run -t tabs@49` - `$ cd ./test-run` - `$ yarn expo run:ios --device` - Select an iOS 17 device (not simulator) - Should install, and boot the app <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Works around issue #24615
This is a dirty workaround and needs further attention. If we want to keep the fast socket connections, we need to implement the new Quic + XPC protocol.
How
com.apple.debugserverservice can't be launched, use the fallback optionxcrun devicectlTest Plan
$ yarn create expo ./test-run -t tabs@49$ cd ./test-run$ yarn expo run:ios --deviceChecklist
npx expo prebuild& EAS Build (eg: updated a module plugin).