Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-launcher] Improve 'Development servers' and 'Recently opened' UX #24665

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

gabrieldonadel
Copy link
Member

@gabrieldonadel gabrieldonadel commented Sep 28, 2023

Why

Closes ENG-10037

How

Update the "Development servers" section to show the server URL so users can differentiate multiple entries with the same title and update the "Recently opened" section to only one local app (the most recent)

Test Plan

Run dev-client through bare-expo on Android and iOS

AndroidiOS

Checklist

@linear
Copy link

linear bot commented Sep 28, 2023

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Sep 28, 2023
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Sep 28, 2023
@@ -21,6 +21,6 @@
**/bin/**
**/fastlane/**
**/ios/**
**/providers/**
**/kotlin/providers/**
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was causing files inside expo-dev-launcher/bundle/providers to not be checked

@gabrieldonadel gabrieldonadel marked this pull request as ready for review September 28, 2023 18:25
@gabrieldonadel gabrieldonadel merged commit 704815a into main Oct 5, 2023
9 of 10 checks passed
@gabrieldonadel gabrieldonadel deleted the @gabrieldonadel/improve-launcher-ux branch October 5, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint changed bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants