Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): improve browser shims #24671

Merged
merged 3 commits into from Sep 29, 2023
Merged

Conversation

EvanBacon
Copy link
Contributor

Why

If a browser shim has a mismatched extension to what is being imported, then it won't be resolved correctly. This change fixes that.

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Sep 29, 2023
EvanBacon and others added 2 commits September 28, 2023 19:03
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Sep 29, 2023
@EvanBacon EvanBacon merged commit 057a9c3 into main Sep 29, 2023
6 of 7 checks passed
@EvanBacon EvanBacon deleted the @evanbacon/cli/metro-resolver-updates branch September 29, 2023 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint changed bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants