Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shim react-native-web BackHandler to remove excessive error message. #24726

Merged
merged 2 commits into from Oct 4, 2023
Merged

Shim react-native-web BackHandler to remove excessive error message. #24726

merged 2 commits into from Oct 4, 2023

Conversation

EvanBacon
Copy link
Contributor

Why

  • The BackHandler is deprecated error message is not helpful and shows up in every project. This change will shim the file to prevent the error from showing.

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Oct 4, 2023
@EvanBacon @expo-bot
Update packages/@expo/cli/CHANGELOG.md
cfaa2c2 
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Oct 4, 2023
@EvanBacon EvanBacon merged commit b97f137 into main Oct 4, 2023
6 of 7 checks passed
@EvanBacon EvanBacon deleted the @evanbacon/cli/shim-back-handler branch October 4, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byCedric byCedric Awaiting requested review from byCedric byCedric is a code owner

@marklawlor marklawlor Awaiting requested review from marklawlor

Assignees
No one assigned
Labels
bot: fingerprint changed bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EvanBacon @expo-bot