refactor(cli): skip loading the telemetry client when disabled #24841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
expo-bot
added
bot: passed checks
EvanBacon
approved these changes
Oct 12, 2023
marklawlor
pushed a commit
that referenced
this pull request
Oct 30, 2023
# Why When the telemetry client is not enabled, we don't have to load it. This does exactly that, mostly for commands that should execute pretty much instantly (like `npx expo config`). # How - Added check before loading the telemetry client in `bin/cli.ts` # Test Plan You can test the performance increase in a project using hyperfine: <img width="891" alt="image" src="https://github.com/expo/expo/assets/1203991/a892cc19-cad0-4f35-b687-31e2ada29147"> # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
When the telemetry client is not enabled, we don't have to load it. This does exactly that, mostly for commands that should execute pretty much instantly (like
npx expo config).How
bin/cli.tsTest Plan
You can test the performance increase in a project using hyperfine:
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).