[ios][application] Migrate to Expo Modules API #24871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expo-bot
added
the
bot: needs changes
reichhartd
force-pushed
the
feat/migrate-expo-application
branch
from
245b70c
to
2bd6222
Compare
expo-bot
added
bot: passed checks
EvanBacon
reviewed
Oct 16, 2023
EvanBacon
approved these changes
Oct 16, 2023
ide
reviewed
Oct 16, 2023
Comment on lines
-121
to
-127
| export enum ApplicationReleaseType { | ||
| UNKNOWN = 0, | ||
| SIMULATOR = 1, | ||
| ENTERPRISE = 2, | ||
| DEVELOPMENT = 3, | ||
| AD_HOC = 4, | ||
| APP_STORE = 5, |
There was a problem hiding this comment.
Prefer the enum over type unions IMO (will defer to @tsapeta). If the issue is that the runtime values of the enums are human-unfriendly, we could make a breaking change to make them be strings (enum { UNKNOWN = 'UNKNOWN', ... }).
alanjhughes
requested changes
Oct 16, 2023
packages/expo-application/ios/ApplicationModuleProvisioningProfile.swift
Outdated
Show resolved
Hide resolved
packages/expo-application/ios/ApplicationModuleProvisioningProfile.swift
Outdated
Show resolved
Hide resolved
packages/expo-application/ios/ApplicationModuleProvisioningProfile.swift
Outdated
Show resolved
Hide resolved
packages/expo-application/ios/ApplicationModuleProvisioningProfile.swift
Outdated
Show resolved
Hide resolved
packages/expo-application/ios/ApplicationModuleProvisioningProfile.swift
Outdated
Show resolved
Hide resolved
packages/expo-application/ios/ApplicationModuleProvisioningProfile.swift
Outdated
Show resolved
Hide resolved
packages/expo-application/ios/ApplicationModuleProvisioningProfile.swift
Outdated
Show resolved
Hide resolved
packages/expo-application/ios/ApplicationModuleProvisioningProfile.swift
Outdated
Show resolved
Hide resolved
packages/expo-application/ios/ApplicationModuleProvisioningProfile.swift
Outdated
Show resolved
Hide resolved
expo-bot
added
bot: suggestions
reichhartd
force-pushed
the
feat/migrate-expo-application
branch
from
737b85f
to
d13f7ed
Compare
expo-bot
added
bot: passed checks
reichhartd
force-pushed
the
feat/migrate-expo-application
branch
from
d13f7ed
to
0d32d95
Compare
alanjhughes
requested changes
Oct 17, 2023
alanjhughes
approved these changes
Oct 17, 2023
alanjhughes
requested changes
Oct 17, 2023
Co-authored-by: Alan Hughes <30924086+alanjhughes@users.noreply.github.com>
Co-authored-by: Alan Hughes <30924086+alanjhughes@users.noreply.github.com>
Co-authored-by: Alan Hughes <30924086+alanjhughes@users.noreply.github.com>
marklawlor
pushed a commit
that referenced
this pull request
Oct 30, 2023
This was referenced Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Migrate to expo modules API.
How
Followed typical migration steps.
There is a breaking change:
getIosPushNotificationServiceEnvironmentAsync()now returns a string of a union type instead of an enum integer. I changed this because I thought it made more sense from a user perspective, it is recommended in the Expo Modules API documentation that way, and TypeScript enums should be avoided in general.Test Plan
Tested on my physical iPhone 11 Pro.
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).