preserve jsx across Expo SDK #24889
Merged
preserve jsx across Expo SDK #24889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
|
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|
EvanBacon
requested review from
ide,
tsapeta,
marklawlor,
Kudo,
lukmccall,
alanjhughes,
aleqsio,
douglowder,
gabrieldonadel and
byCedric
as code owners
tsapeta
approved these changes
Oct 16, 2023
marklawlor
approved these changes
Oct 16, 2023
aleqsio
approved these changes
Oct 17, 2023
lukmccall
approved these changes
Oct 17, 2023
gabrieldonadel
approved these changes
Oct 17, 2023
gabrieldonadel
approved these changes
Oct 17, 2023
marklawlor
added a commit
that referenced
this pull request
Oct 30, 2023
- Revert #8421 - When users transpile jsx, it provides a hook for switching how JSX is handled which is useful for styling tools like nativewind. e.g. Nativewind will be able to easily intercept the View creation in `expo-blur` to add `className` support. - Could be considered a breaking change as bundler implementations will need to target Expo packages and strip JSX, which we already do in Metro and expo/webpack. - Use the tsconfig jsx react-native setting which seemingly does nothing. - build folders will contain JSX left as-is. --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
This was referenced Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
expo-blurto addclassNamesupport.How
Test Plan