chore(splash): upstream Expo Router splash screen changes #24893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can also be used for any other async setup we want to add in the future.
…ter` to `expo-splash-screen`.
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
expo-bot
added
bot: passed checks
EvanBacon
requested review from
Simek,
amandeepmittal,
Kudo and
marklawlor
as code owners
github-actions
bot
added
bot: fingerprint compatible
and removed
bot: fingerprint changed
labels
Kudo
approved these changes
Oct 19, 2023
amandeepmittal
approved these changes
Oct 19, 2023
EvanBacon
requested review from
lukmccall,
douglowder and
gabrieldonadel
as code owners
|
Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines. I've found some issues in your pull request that should be addressed (click on them for more details) 👇
|
expo-bot
added
bot: suggestions
github-actions
bot
added
bot: fingerprint changed
and removed
bot: fingerprint compatible
labels
marklawlor
pushed a commit
that referenced
this pull request
Oct 30, 2023
# Why Expo Router has the ability to delay dismissing the splash screen until additional async work has finished, this functionality could also be used for other features like font loading in the future. Regardless, the changes are pretty light and add some additional value to non-router users, so it makes sense to move them upstream. <!-- Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests. --> # How - Pull in native-only code for delaying the splash screen hiding (when the user hasn't already done this themselves) and attempting to hide when internal tasks have completed. - Memoize `preventAutoHideAsync` to prevent extraneous warnings. - Wrap the `hideAsync` warning to prevent extraneous warnings. We have no way of detecting if the splash has already been hidden so this is the only option. - Add additional error utils to hide the splash screen if an error was thrown, preventing the state where a splash screen hides error info. - Make `expo-router` SplashScreen just a re-export of `expo-splash-screen`. <!-- How did you build this feature or fix this bug and why? --> # Test Plan Manually tested in `apps/router-e2e`. --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Expo Router has the ability to delay dismissing the splash screen until additional async work has finished, this functionality could also be used for other features like font loading in the future. Regardless, the changes are pretty light and add some additional value to non-router users, so it makes sense to move them upstream.
How
preventAutoHideAsyncto prevent extraneous warnings.hideAsyncwarning to prevent extraneous warnings. We have no way of detecting if the splash has already been hidden so this is the only option.expo-routerSplashScreen just a re-export ofexpo-splash-screen.Test Plan
Manually tested in
apps/router-e2e.