feat(router): add target, rel, and download to Link component #24908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanBacon
requested review from
Simek,
amandeepmittal and
marklawlor
as code owners
ENG-10305 Add target, rel, download props to Link
These are available as |
EvanBacon
changed the title
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
expo-bot
added
bot: passed checks
marklawlor
pushed a commit
that referenced
this pull request
Oct 30, 2023
# Why Resolve ENG-10305 # How Add support for the `target`, `rel`, and `download` attributes. The only caveat is that if you use `<Link asChild><Text /></Link>` the values won't work, they would need to be transformed to `hrefAttrs: { ... }` for React Native Web. # Test Plan Added tests for the rendering on native and web. --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Resolve ENG-10305
How
Add support for the
target,rel, anddownloadattributes. The only caveat is that if you use<Link asChild><Text /></Link>the values won't work, they would need to be transformed tohrefAttrs: { ... }for React Native Web.Test Plan
Added tests for the rendering on native and web.