Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[expo-localization] Remove deprecated methods from mocks #25078

Merged
merged 3 commits into from Oct 30, 2023
Merged

[expo-localization] Remove deprecated methods from mocks #25078

merged 3 commits into from Oct 30, 2023

Conversation

aleqsio
Copy link
Contributor

@aleqsio aleqsio commented Oct 27, 2023

Why

This PR just removes some methods from docs that we deprecated a few months ago. It makes the docs clearer and less cluttered.

How

Test Plan

Checklist

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Oct 27, 2023
amandeepmittal
amandeepmittal approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@amandeepmittal amandeepmittal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggestion to add inline syntax highlight but rest lgtm! Thank you for cleaning this!

packages/expo-localization/src/Localization.ts Outdated Show resolved Hide resolved
aleqsio and others added 2 commits October 30, 2023 14:49
@aleqsio @amandeepmittal
Update packages/expo-localization/src/Localization.ts
fd39e20 
Co-authored-by: Aman Mittal <amandeepmittal@live.com>
@aleqsio
Add changelog notice
1f3ed36
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Oct 30, 2023
@aleqsio aleqsio merged commit 831925c into main Oct 30, 2023
13 of 14 checks passed
@aleqsio aleqsio deleted the @aleqsio/hide-deprecated-methods-from-expo-localization branch October 30, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amandeepmittal amandeepmittal amandeepmittal approved these changes

@Simek Simek Awaiting requested review from Simek Simek is a code owner

@EvanBacon EvanBacon Awaiting requested review from EvanBacon EvanBacon is a code owner

Assignees
No one assigned
Labels
bot: fingerprint changed bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aleqsio @Simek @amandeepmittal @expo-bot