-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(metro-config)!: Enable inlineRequires by default #25089
Merged
EvanBacon
merged 10 commits into
main
from
@evanbacon/metro-config/enable-inlineRequires
Nov 2, 2023
Merged
feat(metro-config)!: Enable inlineRequires by default #25089
EvanBacon
merged 10 commits into
main
from
@evanbacon/metro-config/enable-inlineRequires
Nov 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentvatne
approved these changes
Oct 27, 2023
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
github-actions
bot
added
bot: fingerprint changed
and removed
bot: fingerprint compatible
labels
Oct 31, 2023
expo-bot
added
bot: passed checks
ExpoBot has nothing to complain about
and removed
bot: suggestions
ExpoBot has some suggestions
labels
Oct 31, 2023
expo-bot
added
bot: suggestions
ExpoBot has some suggestions
and removed
bot: passed checks
ExpoBot has nothing to complain about
labels
Oct 31, 2023
expo-bot
added
bot: passed checks
ExpoBot has nothing to complain about
and removed
bot: suggestions
ExpoBot has some suggestions
labels
Nov 2, 2023
EvanBacon
requested review from
lukmccall,
douglowder and
gabrieldonadel
as code owners
November 2, 2023 18:35
expo-bot
added
bot: needs changes
ExpoBot found things that don't meet our guidelines
and removed
bot: passed checks
ExpoBot has nothing to complain about
labels
Nov 2, 2023
expo-bot
added
bot: suggestions
ExpoBot has some suggestions
and removed
bot: needs changes
ExpoBot found things that don't meet our guidelines
labels
Nov 2, 2023
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
expo-bot
added
bot: passed checks
ExpoBot has nothing to complain about
and removed
bot: suggestions
ExpoBot has some suggestions
labels
Nov 2, 2023
EvanBacon
added a commit
that referenced
this pull request
Dec 1, 2023
# Why This PR reverts #25089 where we enabled inlineRequires by default. The inline requires feature doesn't work as-is because it does not respect module side-effects. Due to the way inline requires is computed in the transformer, it has no ability to determine if a module should be automatically skipped to prevent breaking the expected order of instantiation. --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
onizam95
pushed a commit
to onizam95/expo-av-drm
that referenced
this pull request
Jan 15, 2024
# Why This PR reverts expo#25089 where we enabled inlineRequires by default. The inline requires feature doesn't work as-is because it does not respect module side-effects. Due to the way inline requires is computed in the transformer, it has no ability to determine if a module should be automatically skipped to prevent breaking the expected order of instantiation. --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Align with upstream defaults more closely. This feature may cause unexpected behavior with global side-effects so I'm marking it as a breaking change. Users can disable the feature:
Test Plan
Checklist
npx expo prebuild
& EAS Build (eg: updated a module plugin).