(router): fix relative hrefs inside groups #25111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marklawlor
changed the title
expo-bot
added
bot: suggestions
|
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
marklawlor
force-pushed
the
marklawlor/24789
branch
from
4600459
to
117bfa3
Compare
EvanBacon
approved these changes
Nov 6, 2023
|
Thank you! |
marklawlor
added a commit
to expo/router
that referenced
this pull request
Nov 7, 2023
backport of expo/expo#25111
marklawlor
added a commit
to expo/router
that referenced
this pull request
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Relative links do not work inside groups.
Fix: #24789
Fix: #24787
Fix: #24787
How
We were rebuilding the current URL based upon the rootState. However we were supplying insufficient information (no
screens, which includes thepatterndata). However we don't actually need to perform this calculation, as the store always has the current href (which is uses for hooks likeusePathname())Test Plan
Added new test. Tested against reported issues
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).