feat(cli): Pass unstable_transformProfile to export(:embed) automatically if targeting hermes #25132

EvanBacon · 2023-10-31T04:02:53Z

Why

Production bundling can skip minification if targeting Hermes because Hermes will perform minification during bytecode creation.

Two concerns:

I can't find any docs on Hermes minification so it's unclear to me if the results are suboptimal.
If a user is building an app manually and the app.json is out of sync with the native project settings, then they could end up not minifying their JSC project source.

…geting hermes

Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>

@gabrieldonadel

# Why @gabrieldonadel reported an issue in https://github.com/expo/expo/blob/ed860e5e2478a5f9994ffa5682f7a7dff5bdd63c/packages/expo-dev-launcher/ios/main.jsbundle where the bundle size is doubled. the root cause is from #25132 and we use `export:embed` without specifying jsEngine in expo-dev-menu & expo-dev-launcher. that would use hermes transform profiler and not minify the bundle. # How specify the default transform profile because the bundles should support JSC as well. # Test Plan check the bundle sizes are under 2.5MB # Checklist - n/a Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - fixing issues before publishing packages - [x] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).

Pass unstable_transformProfile to export(:embed) automatically if tar…

6ce8110

…geting hermes

EvanBacon requested a review from byCedric as a code owner October 31, 2023 04:02

github-actions bot added the bot: fingerprint changed label Oct 31, 2023

expo-bot added the bot: suggestions ExpoBot has some suggestions label Oct 31, 2023

EvanBacon and others added 3 commits October 31, 2023 12:29

Merge branch 'main' into @evanbacon/cli/export-for-hermes

91f7a65

Update CHANGELOG.md

76dfd3e

Update packages/@expo/cli/CHANGELOG.md

da25ae6

Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>

expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Oct 31, 2023

EvanBacon merged commit 818d377 into main Oct 31, 2023
5 of 7 checks passed

EvanBacon deleted the @evanbacon/cli/export-for-hermes branch October 31, 2023 23:15

Kudo mentioned this pull request Nov 2, 2023

[dev-menu][dev-launcher] use default transform profile #25174

Merged

2 tasks