feat(cli): pass engine to metro in production #25175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
expo-bot
added
bot: passed checks
2 tasks
Kudo
added a commit
that referenced
this pull request
Nov 3, 2023
# Why fix ci failure: https://github.com/expo/expo/runs/18313114066 # How since #25175 was landed, we were now bundling with `unstable_transformProfile=default` and `customTransformOptions=hermes`. that is not quite correct. @EvanBacon suggests that we could have **app.json** and `npx expo export:embed` could based on it to generate correct bundles. this pr adds temporary **app.json** with `jsEngine=jsc` and cleanup the file after that. then the **app.json** will not appear in final npm package. # Test Plan SDK ci passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Missed this part when implementing the engine flag.
How
Test Plan
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).