chore: rename basePath to baseUrl #25305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanBacon
requested review from
Simek,
amandeepmittal,
marklawlor,
brentvatne,
ide and
byCedric
as code owners
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
expo-bot
added
bot: passed checks
Co-authored-by: Aman Mittal <amandeepmittal@live.com> Co-authored-by: James Ide <ide@users.noreply.github.com>
EvanBacon
removed request for
brentvatne,
Simek,
byCedric,
tsapeta and
douglowder
onizam95
pushed a commit
to onizam95/expo-av-drm
that referenced
this pull request
Jan 15, 2024
# Why TypeScript and Vite use [baseUrl](https://vitejs.dev/guide/build.html#public-base-path) which I like more than `basePath` because it reflects that an absolute URL can be used. Additionally, I want to use an inlined environment variable instead of Expo config to ensure the behavior between platforms is uniform and expected. Finally, we pass baseUrl down to the transformer now which means the caching will automatically be invalidated when it changes. I'm also setting us up to expose more transform settings as `EXPO_` environment variables. e.g. `EXPO_OS` (or `EXPO_PLATFORM`) as a way to detect the platform without importing `react-native` / `react-native-web`. # Test Plan - basePath had good test coverage, running some things locally just to be safe. # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com> Co-authored-by: Aman Mittal <amandeepmittal@live.com> Co-authored-by: James Ide <ide@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
TypeScript and Vite use baseUrl which I like more than
basePathbecause it reflects that an absolute URL can be used.Additionally, I want to use an inlined environment variable instead of Expo config to ensure the behavior between platforms is uniform and expected.
Finally, we pass baseUrl down to the transformer now which means the caching will automatically be invalidated when it changes.
I'm also setting us up to expose more transform settings as
EXPO_environment variables. e.g.EXPO_OS(orEXPO_PLATFORM) as a way to detect the platform without importingreact-native/react-native-web.Test Plan
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).