fix(cli): upgrade arg to fix uncaught user errors
#25329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byCedric
force-pushed
the
@bycedric/cli/upgrade-arg-and-error-handling
branch
from
1748684
to
466f4a7
Compare
expo-bot
added
bot: passed checks
3 tasks
EvanBacon
approved these changes
Nov 11, 2023
onizam95
pushed a commit
to onizam95/expo-av-drm
that referenced
this pull request
Jan 15, 2024
# Why We currently still use `arg@4.x.x`, where some errors do not have a proper `.code` property. This results in the error handling not catching it, and making it feel that the CLI actually crashed instead of "denied" the command. ### Before this PR <img width="986" alt="image" src="https://github.com/expo/expo/assets/1203991/ec893c11-fb9c-4764-8d12-07e3a32b3b58"> ### After this PR <img width="323" alt="image" src="https://github.com/expo/expo/assets/1203991/8b874ae6-87b1-4491-9c7b-beedbd07d989"> # How - Upgraded to `arg@5.0.2`, which includes better errors ([with `.code` properties](https://github.com/vercel/arg/releases/tag/5.0.0)) - Updated the error handling to handle `ARG_` errors, which are not `ARG_CONFIG_` errors # Test Plan - Existing test cases - Run `$ expo run:android --variant` - ~~Run `$ expo run:android --port="hello"`~~ Well, forgot that `NaN` is actually a valid `Number` # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We currently still use
arg@4.x.x, where some errors do not have a proper.codeproperty. This results in the error handling not catching it, and making it feel that the CLI actually crashed instead of "denied" the command.Before this PR
After this PR
How
arg@5.0.2, which includes better errors (with.codeproperties)ARG_errors, which are notARG_CONFIG_errorsTest Plan
$ expo run:android --variantRunWell, forgot that$ expo run:android --port="hello"NaNis actually a validNumberChecklist
npx expo prebuild& EAS Build (eg: updated a module plugin).