feat(cli): Ensure invalid production iOS builds fail more predictably. #25410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ENG-10524 Delete previous release bundle when running a new release build for iOS/Android
Related: ENG-10223 Dan Abramov commented: "every release build should start by deleting the previous bundle" - I'm inclined to agree! We can potentially backport this to SDK 49 as well. I suspect we could handle this in Expo CLI as part of the |
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
expo-bot
added
bot: passed checks
onizam95
pushed a commit
to onizam95/expo-av-drm
that referenced
this pull request
Jan 15, 2024
expo#25410) # Why - fix ENG-10524 - Guess where the iOS bundle was copied to and delete it. - Strip ansi from error messages when the process is running in xcodebuild/compiler. - Use xcode log compilation format to support first-class errors in Xcode. <img width="1364" alt="Screenshot 2023-11-15 at 7 50 54 PM" src="https://github.com/expo/expo/assets/9664363/af3581cd-9cbc-4bd8-9973-117faa8b3f53"> <img width="954" alt="Screenshot 2023-11-15 at 7 52 48 PM" src="https://github.com/expo/expo/assets/9664363/dfd4244d-a1d7-45fe-8ffd-8891f64b39c6"> <img width="499" alt="Screenshot 2023-11-15 at 8 27 26 PM" src="https://github.com/expo/expo/assets/9664363/5cf4f41a-4cc8-4946-986f-3d49006bc96b"> <!-- Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests. --> # How <!-- How did you build this feature or fix this bug and why? --> # Test Plan Tested Release builds in Xcode with CLI_PATH set to the local CLI: ``` export CLI_PATH=/Users/evanbacon/Documents/GitHub/expo/packages/@expo/cli/build/bin/cli ``` Added some unit tests for the more fragile logic. <!-- Please describe how you tested this change and how a reviewer could reproduce your test, especially if this PR does not include automated tests! If possible, please also provide terminal output and/or screenshots demonstrating your test/reproduction. --> # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
How
Test Plan
Tested Release builds in Xcode with CLI_PATH set to the local CLI:
Added some unit tests for the more fragile logic.
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).