refactor(metro-config): replace @expo/babel-preset-cli with expo-module-scripts
#25421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expo-bot
added
bot: suggestions
3 tasks
byCedric
changed the title
expo-module-scripts@expo/babel-preset-cli with expo-module-scripts
marklawlor
approved these changes
Nov 20, 2023
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
…g the CLI presets
byCedric
force-pushed
the
@bycedric/metro-config/drop-babel-preset-cli
branch
from
bc2e078
to
1a82849
Compare
byCedric
force-pushed
the
@bycedric/metro-config/drop-babel-preset-cli
branch
from
116aae3
to
43412ef
Compare
This package has the `files` property configured in **package.json**.
EvanBacon
approved these changes
Nov 22, 2023
alanjhughes
pushed a commit
that referenced
this pull request
Nov 22, 2023
…odule-scripts` (#25421) ~~⚠️ On hold until #25458 is merged.~~ → ✅ merged & (re)based # Why We are deprecating the `@expo/babel-preset-cli`, and that means that other packages need to move over to `expo-module-scripts`. See #25426 for all PRs. # How - Added `expo-module-scripts@^3.3.0` to `devDependencies` - Replaced **package.json** scripts with `expo-module-scripts` equivalents # Test Plan See if CI passes. # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [x] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com> Co-authored-by: Evan Bacon <bacon@expo.io>
byCedric
added a commit
that referenced
this pull request
Nov 23, 2023
…odule-scripts` (#25426) ~~⚠️ On hold until all listed PRs are merged.~~ → ✅ ~~⚠️ On hold until #25458 is merged.~~ → ✅ merged & (re)based # Why We are deprecating the `@expo/babel-preset-cli`, and that means that other packages need to move over to `expo-module-scripts`. This is the final PR to get rid of `@expo/babel-preset-cli` from this repository. But, as this is the only package adding this library to this monorepo, _**we need to merge this as last one**_. Otherwise, all other packages using `@expo/babel-preset-cli` will not install this package. Other clean-up PRs: - #25416 - #25417 - #25418 - #25420 - #25421 - #25422 - #25423 - #25424 - #25425 # How - Added `expo-module-scripts@^3.3.0` to `devDependencies` - Replaced **package.json** scripts with `expo-module-scripts` equivalents # Test Plan See if CI passes. # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [x] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
onizam95
pushed a commit
to onizam95/expo-av-drm
that referenced
this pull request
Jan 15, 2024
…odule-scripts` (expo#25421) ~~⚠️ On hold until expo#25458 is merged.~~ → ✅ merged & (re)based # Why We are deprecating the `@expo/babel-preset-cli`, and that means that other packages need to move over to `expo-module-scripts`. See expo#25426 for all PRs. # How - Added `expo-module-scripts@^3.3.0` to `devDependencies` - Replaced **package.json** scripts with `expo-module-scripts` equivalents # Test Plan See if CI passes. # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [x] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com> Co-authored-by: Evan Bacon <bacon@expo.io>
onizam95
pushed a commit
to onizam95/expo-av-drm
that referenced
this pull request
Jan 15, 2024
…odule-scripts` (expo#25426) ~~⚠️ On hold until all listed PRs are merged.~~ → ✅ ~~⚠️ On hold until expo#25458 is merged.~~ → ✅ merged & (re)based # Why We are deprecating the `@expo/babel-preset-cli`, and that means that other packages need to move over to `expo-module-scripts`. This is the final PR to get rid of `@expo/babel-preset-cli` from this repository. But, as this is the only package adding this library to this monorepo, _**we need to merge this as last one**_. Otherwise, all other packages using `@expo/babel-preset-cli` will not install this package. Other clean-up PRs: - expo#25416 - expo#25417 - expo#25418 - expo#25420 - expo#25421 - expo#25422 - expo#25423 - expo#25424 - expo#25425 # How - Added `expo-module-scripts@^3.3.0` to `devDependencies` - Replaced **package.json** scripts with `expo-module-scripts` equivalents # Test Plan See if CI passes. # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [x] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⚠️ On hold until #25458 is merged.Why
We are deprecating the
@expo/babel-preset-cli, and that means that other packages need to move over toexpo-module-scripts.See #25426 for all PRs.
How
expo-module-scripts@^3.3.0todevDependenciesexpo-module-scriptsequivalentsTest Plan
See if CI passes.
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).