[metro-config] add missing dependency #25446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douglowder
requested review from
EvanBacon,
byCedric and
marklawlor
as code owners
douglowder
requested review from
wschurman
and removed request for
marklawlor
douglowder
force-pushed
the
doug/fix-metro-config-dep
branch
from
9a3b5fc
to
f954de6
Compare
expo-bot
added
bot: passed checks
EvanBacon
approved these changes
Nov 17, 2023
onizam95
pushed a commit
to onizam95/expo-av-drm
that referenced
this pull request
Jan 15, 2024
# Why Changes in expo#25369 in metro-config have broken `npx expo export` and therefore `eas update`, due to a new reference to the `path-to-regexp` module. # How Add the correct dependency in `@expo/metro-config`. # Test Plan Manual testing with an app generated with `packages/expo-updates/e2e/setup/create-updates-test.ts`, to verify that `eas update` works again. # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Changes in #25369 in metro-config have broken
npx expo exportand thereforeeas update, due to a new reference to thepath-to-regexpmodule.How
Add the correct dependency in
@expo/metro-config.Test Plan
Manual testing with an app generated with
packages/expo-updates/e2e/setup/create-updates-test.ts, to verify thateas updateworks again.Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).