chore(babel-preset-expo, metro-config): Move majority of babel plugins to babel preset expo #25461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
expo-bot
added
bot: passed checks
byCedric
reviewed
Nov 19, 2023
EvanBacon
requested review from
brentvatne,
ide and
marklawlor
as code owners
EvanBacon
deleted the
@evanbacon/metro-config/move-all-config-to-babel-preset-expo
branch
onizam95
pushed a commit
to onizam95/expo-av-drm
that referenced
this pull request
Jan 15, 2024
…s to babel preset expo (expo#25461) # Why Metro's default design injects babel plugins across a number of different transformation layers and files. This makes working with Expo/React Native extremely confusing. This PR aims to move the majority of babel-related logic to `babel-preset-expo`. This has the following benefits: - Babel has a standard plugin system, Metro does not, by offloading more transformation to Babel we effectively enable a Babel-based plugin architecture for Expo Metro users. - By moving more of the options to Babel via the caller we can preserve the caching behavior from before but with less fragmentation as we do most config caching in Babel. - Having most the transformations in one place makes it easier to reason about how source must be transformed to work in Expo-supported runtimes. This makes it easier to migrate to other tools like SWC by rewriting babel-preset-expo, as opposed to by rewriting metro-transform-worker, metro-babel-transformer, and metro-babel-preset-react-native. - Fix ENG-10578 This PR also fixes a weird edge case where the import behavior works differently when no babel config exists. We'll do another pass to unify this logic in the future by passing the inlineRequires and transform support as caller options. <!-- Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests. --> # How Consolidate our `transformer.babelTransformerPath` implementation and move the additional babel plugins to `babel-preset-expo`. We also drop the inlineRequires transform which is already applied in the `metro-transform-worker` here https://github.com/facebook/metro/blob/55b45becb1fbb4237ecc5fd0d2c81f199aefe09e/packages/metro-transform-worker/src/index.js#L293-L301 -- this also matches the upstream change facebook/react-native#38771 # Test Plan - Added new tests for the babel transforms. --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Metro's default design injects babel plugins across a number of different transformation layers and files. This makes working with Expo/React Native extremely confusing. This PR aims to move the majority of babel-related logic to
babel-preset-expo. This has the following benefits:This PR also fixes a weird edge case where the import behavior works differently when no babel config exists. We'll do another pass to unify this logic in the future by passing the inlineRequires and transform support as caller options.
How
Consolidate our
transformer.babelTransformerPathimplementation and move the additional babel plugins tobabel-preset-expo.We also drop the inlineRequires transform which is already applied in the
metro-transform-workerhere https://github.com/facebook/metro/blob/55b45becb1fbb4237ecc5fd0d2c81f199aefe09e/packages/metro-transform-worker/src/index.js#L293-L301 -- this also matches the upstream change facebook/react-native#38771Test Plan