[router][iOS] Remove unused dateModified field from MetadataOptions #25467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
gabrieldonadel
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Fixes https://github.com/expo/expo/actions/runs/6915407980/job/18814302536 that started failing due to #25390
The MetadataOptions includes a
Fieldthat wraps aDatewhich is not conforming toAnyArgumentbecause it's not a convertible type (yet).How
This field doesn't seem to be used on the iOS side, so I think we can just remove it.
I plan to make
Datea convertible type in the future.Test Plan
Expo Go on iOS compiles