chore(babel-preset-expo, jest-expo, cli)!: Move react-native-vector-icons alias to resolvers #25512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
expo-bot
added
bot: passed checks
onizam95
pushed a commit
to onizam95/expo-av-drm
that referenced
this pull request
Jan 15, 2024
…cons alias to resolvers (expo#25512) # Why Aliases in the resolver are more resilient (no chance of differences in importing logic between babel plugin and bundler), faster (no additional AST traversal needed), and easier to cache (cache based on input context rather than AST). # How This PR removes the need to perform an additional import traversal to replace `react-native-vector-icons` with `@expo/vector-icons` by moving the alias to a conditional resolver in both Metro and Jest as opposed to having it in `babel-preset-expo` with `babel-plugin-module-resolver`. To preserve backwards compatibility, I've also added support for nested imports, e.g. `react-native-vector-icons/FontAwesome` -> `@expo/vector-icons/FontAwesome`, even though we don't perform a strict check on the import existence. # Test Plan - Added new tests for the resolver. - Removed old tests for babel. - Existing code using Jest should continue to work. --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Aliases in the resolver are more resilient (no chance of differences in importing logic between babel plugin and bundler), faster (no additional AST traversal needed), and easier to cache (cache based on input context rather than AST).
How
This PR removes the need to perform an additional import traversal to replace
react-native-vector-iconswith@expo/vector-iconsby moving the alias to a conditional resolver in both Metro and Jest as opposed to having it inbabel-preset-expowithbabel-plugin-module-resolver.To preserve backwards compatibility, I've also added support for nested imports, e.g.
react-native-vector-icons/FontAwesome->@expo/vector-icons/FontAwesome, even though we don't perform a strict check on the import existence.Test Plan