[cli] Fix @react-native/dev-middleware types #25513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrieldonadel
force-pushed
the
@gabrieldonadel/react-native-dev-middleware-types
branch
2 times, most recently
from
44dfecb
to
72b8358
Compare
gabrieldonadel
force-pushed
the
@gabrieldonadel/react-native-dev-middleware-types
branch
from
72b8358
to
982fab2
Compare
expo-bot
added
bot: passed checks
byCedric
reviewed
Nov 27, 2023
| // _mapToDevicePageId | ||
| } | ||
| declare module '@react-native/dev-middleware' { | ||
| type DebuggerInfo = NonNullable<unstable_Device['_debuggerConnection']>; |
There was a problem hiding this comment.
Note to self, check if this is still necessary, or if we can use it in a better way (more @react-native/dev-middleware-contract compliant way)
byCedric
reviewed
Nov 27, 2023
Comment on lines
+68
to
+70
| newDevice.handleDebuggerConnection(oldDebugger.socket, oldDebugger.pageId, { | ||
| userAgent: oldDebugger.userAgent, | ||
| }); |
There was a problem hiding this comment.
Not 100% set on the userAgent name, it works like a user agent, but its not implemented as such (so probably something needs to change on that -- not sure what yet)
There was a problem hiding this comment.
It's the name used by @react-native/dev-middleware so we might need to live with it
byCedric
approved these changes
Nov 28, 2023
gabrieldonadel
deleted the
@gabrieldonadel/react-native-dev-middleware-types
branch
onizam95
pushed a commit
to onizam95/expo-av-drm
that referenced
this pull request
Jan 15, 2024
# Why When upgrading to react-native 0.73 a few things changed inside the @react-native/dev-middleware, but as we were overwriting the module types with our own declarations a few errors went unnoticed # How Refactor @react-native/dev-middleware type declaration to be as simple as possible # Test Plan Typescript check should be green # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
When upgrading to react-native 0.73 a few things changed inside the @react-native/dev-middleware, but as we were overwriting the module types with our own declarations a few errors went unnoticed
How
Refactor @react-native/dev-middleware type declaration to be as simple as possible
Test Plan
Typescript check should be green
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).