fix(router): Ensure url params are decoded consistently across expo-router #25589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expo-bot
added
bot: passed checks
marklawlor
requested review from
tsapeta,
brentvatne,
Kudo,
Simek,
amandeepmittal,
ide,
wschurman,
douglowder,
lukmccall,
alanjhughes and
byCedric
as code owners
expo-bot
added
bot: suggestions
marklawlor
force-pushed
the
marklawlor/router/decodeUriComponent
branch
from
17c041d
to
a462fe8
Compare
expo-bot
added
bot: passed checks
ide
reviewed
Nov 28, 2023
marklawlor
removed request for
Kudo,
brentvatne,
wschurman,
Simek,
byCedric,
tsapeta,
douglowder and
lukmccall
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
marklawlor
force-pushed
the
marklawlor/router/decodeUriComponent
branch
from
c69b612
to
12ed264
Compare
ide
approved these changes
Dec 5, 2023
onizam95
pushed a commit
to onizam95/expo-av-drm
that referenced
this pull request
Jan 15, 2024
…outer (expo#25589) # Why `useGlobalSearchParams` and `useLocalSearchParams` treat URL search parameters differently. Fix expo#25570 Fix expo#25323 # How I'm not 100% happy with this solution, I thought we could do it more in the `getStateFromPath`/`getPathFromState` but I couldn't get it working. Instead we just decode them directly before saving to the global store, or when accessing from the navigation context. # Test Plan Unit tests cover multiple scenarios, ensuring the parameters are consistently decoded. # Checklist <!-- Please check the appropriate items below if they apply to your diff. This is required for changes to Expo modules. --> - [ ] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [ ] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [ ] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
|
Noob here. Just updated to sdk50 from 49. If I pass a firebase image url through local params It becomes invalid due to the decoding removing %2f. Use case is searching a user and then passing the details to profile screen. error for image: There a way to revert or disable decoding? |
|
It sounds like the custom parameters might need to be URL-encoded when serializing them. For now you could probably work around the issue by double-encoding your URL. |
|
Thanks, works for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
useGlobalSearchParamsanduseLocalSearchParamstreat URL search parameters differently.Fix #25570
Fix #25323
How
I'm not 100% happy with this solution, I thought we could do it more in the
getStateFromPath/getPathFromStatebut I couldn't get it working. Instead we just decode them directly before saving to the global store, or when accessing from the navigation context.Test Plan
Unit tests cover multiple scenarios, ensuring the parameters are consistently decoded.
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).