Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[babel-preset] Update reanimated test snapshots #25644

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

gabrieldonadel
Copy link
Member

Why

After upgrading reanimated to 3.6.0 babel-preset-expo snapshots no longer work

How

Run yarn test -u inside packages/babel-preset-expo

Test Plan

CI should be green

Checklist

Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Nov 29, 2023
@gabrieldonadel gabrieldonadel merged commit 42cd7f0 into main Nov 29, 2023
8 checks passed
@gabrieldonadel gabrieldonadel deleted the @gabrieldonadel/update-babel-preset-snapshots branch November 29, 2023 17:57
onizam95 pushed a commit to onizam95/expo-av-drm that referenced this pull request Jan 15, 2024
# Why

After upgrading reanimated to 3.6.0 babel-preset-expo snapshots no
longer work


# How

Run `yarn test -u` inside packages/babel-preset-expo

# Test Plan

CI should be green

# Checklist

<!--
Please check the appropriate items below if they apply to your diff.
This is required for changes to Expo modules.
-->

- [ ] Documentation is up to date to reflect these changes (eg:
https://docs.expo.dev and README.md).
- [ ] Conforms with the [Documentation Writing Style
Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md)
- [ ] This diff will work correctly for `npx expo prebuild` & EAS Build
(eg: updated a module plugin).

---------

Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: fingerprint changed bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants