Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use build dir for metro-runtime #25655

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

EvanBacon
Copy link
Contributor

Why

Ensure files pull from the build directory. I guess we may have changed this to reduce web bundle size. Can take a pass at fixing that later.

@expo-bot
Copy link
Collaborator

Hi there! 👋 I'm a bot whose goal is to ensure your contributions meet our guidelines.

I've found some issues in your pull request that should be addressed (click on them for more details) 👇

⚠️ Suggestion: Missing links in changelog entries


I've added some suggestions below, you can just apply and commit them 😉


Generated by ExpoBot 🤖 against a71524a

packages/@expo/metro-runtime/CHANGELOG.md Outdated Show resolved Hide resolved
packages/expo-router/CHANGELOG.md Outdated Show resolved Hide resolved
@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Nov 30, 2023
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
@EvanBacon EvanBacon merged commit 5bc03ef into main Nov 30, 2023
@EvanBacon EvanBacon deleted the @evanbacon/metro-runtime/fix-build-output branch November 30, 2023 03:41
onizam95 pushed a commit to onizam95/expo-av-drm that referenced this pull request Jan 15, 2024
# Why

Ensure files pull from the build directory. I guess we may have changed
this to reduce web bundle size. Can take a pass at fixing that later.

---------

Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants