fix(metro-config): patch missing request parameters for react native default code loading #25686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
expo-bot
added
bot: passed checks
brentvatne
reviewed
Dec 1, 2023
Comment on lines
+20
to
+34
| function isEnableHermesManaged( | ||
| expoConfig: Partial<Pick<ExpoConfig, 'ios' | 'android' | 'jsEngine'>>, | ||
| platform: string | ||
| ): boolean { | ||
| switch (platform) { | ||
| case 'android': { | ||
| return (expoConfig.android?.jsEngine ?? expoConfig.jsEngine) !== 'jsc'; | ||
| } | ||
| case 'ios': { | ||
| return (expoConfig.ios?.jsEngine ?? expoConfig.jsEngine) !== 'jsc'; | ||
| } | ||
| default: | ||
| return false; | ||
| } | ||
| } |
There was a problem hiding this comment.
this could potentially be a problem for projects that use expo-router but not CNG/dev-client
onizam95
pushed a commit
to onizam95/expo-av-drm
that referenced
this pull request
Jan 15, 2024
…default code loading (expo#25686) # Why Ensure the correct expo router entry and JS engine is used when bundling. <!-- Please describe the motivation for this PR, and link to relevant GitHub issues, forums posts, or feature requests. --> # How - Infer the props based on a loose copy of what we do in the manifest middleware :[ - Add a memoized warning log for future debugging. <!-- How did you build this feature or fix this bug and why? --> # Test Plan - Added unit tests for new mutations. - Copied patch to Brent's project and ensured it worked. --------- Co-authored-by: Expo Bot <34669131+expo-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Ensure the correct expo router entry and JS engine is used when bundling.
How
Test Plan